Skip to content

Conversation

@s7santosh
Copy link
Contributor

Signed-off-by: Santosh Kumar s7santosh@gmail.com

#419 Added doc update how to start chaincode as a service, and how to set grpc parameters in the startup

s7santosh added 6 commits May 15, 2024 18:22
…grpc parameters in the startup

Signed-off-by: Santosh Kumar <s7santosh@gmail.com>
Signed-off-by: Santosh Kumar <s7santosh@gmail.com>
Signed-off-by: Santosh Kumar <s7santosh@gmail.com>
Signed-off-by: Santosh Kumar <s7santosh@gmail.com>
Signed-off-by: Santosh Kumar <s7santosh@gmail.com>
Signed-off-by: Santosh Kumar <s7santosh@gmail.com>
@s7santosh s7santosh requested a review from a team as a code owner May 24, 2024 06:41
mbwhite
mbwhite previously approved these changes May 24, 2024
Copy link
Member

@bestbeforetoday bestbeforetoday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation for chaincode-as-a-service all appears under the Usage sub-heading of the Chaincode Interface section of the document. For clarity, it might be better to have either:

  1. A specific section for chaincode-as-a-service; or
  2. A sub-heading for chaincode-as-a-service under both the Contract Interface and Chaincode Interface sections, with information relevant to those APIs.

The low-level chaincode interface was superseded by the higher-level contract interface with Fabric v1.4. We should be directing users to the contract interface. I don't mind having chaincode interface information here for completeness, but it should be secondary to the contract interface. I would be equally happy to remove the chaincode interface content.

Not an issue with the changes you've made, but I notice that there are errors in the example code. Really any code samples we include in the documentation should be correct. Alternatively we could reference known good sample code, either in this repository or in the fabric-samples respository. No need to tackle that in this PR though.

Signed-off-by: Santosh Kumar <s7santosh@gmail.com>
@s7santosh
Copy link
Contributor Author

@bestbeforetoday Thank you for your inputs. I have made some changes as per your inputs. Please review it. Thank you!

Copy link
Member

@bestbeforetoday bestbeforetoday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thank you for the contribution!

@bestbeforetoday bestbeforetoday merged commit a1f421b into hyperledger:main May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants