Skip to content

Conversation

bestbeforetoday
Copy link
Member

@bestbeforetoday bestbeforetoday commented May 11, 2024

Build with source and target bytecode compatibility for Java 8. This allows chaincode implementation code that requires Java 8 compatibility to compile against the fabric-chaincode-shim package.

Avoid use of mavenLocal() and (deprecated) jcenter() Gradle repositories.

@bestbeforetoday bestbeforetoday changed the title Update test dependencies following v.5.2 release Update test dependencies following v2.5.2 release May 11, 2024
@bestbeforetoday bestbeforetoday force-pushed the java-version branch 2 times, most recently from 8fab94f to f5061d5 Compare May 12, 2024 10:27
@bestbeforetoday bestbeforetoday changed the title Update test dependencies following v2.5.2 release Restore Java 8 compatibility May 12, 2024
@bestbeforetoday bestbeforetoday force-pushed the java-version branch 3 times, most recently from 6daa8bd to 7f195a5 Compare May 12, 2024 11:54
Build with source and target bytecode compatibility for Java 8. This
allows chaincode implementation code that requires Java 8 compatibility
to compile against the fabric-chaincode-shim package.

Avoid use of mavenLocal() and (deprecated) jcenter() Gradle repositories.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@bestbeforetoday bestbeforetoday marked this pull request as ready for review May 12, 2024 13:10
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner May 12, 2024 13:10
@bestbeforetoday bestbeforetoday enabled auto-merge (squash) May 15, 2024 10:50
Copy link
Contributor

@MuthuSundaravadivel MuthuSundaravadivel May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the fabric-chaincode-shim:2.5.2 version needs to be changed fabric-chaincode-shim:2.5.3. Line No:24. I will create the separate PR that way i can understand process

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the fabric-chaincode-shim:2.5.2 version needs to be changed fabric-chaincode-shim:2.5.3 Line No 17. I will create the separate PR that way i can understand process

Copy link
Contributor

@MuthuSundaravadivel MuthuSundaravadivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In examples we need to change the version from 2.5.2 to 2.5.3. I will create the separate PR that way i can understand process. Apart from this i have couple of question can you guys help me to clarify my question.

  1. Does the vulnerability scan action check every dependency that the Java SDK uses?

  2. The ubuntu-latest job is executed whenever a PR is merged, its handling the build, jar, and image pushes to the registry. How will the tagging take place? Do I need to run git tag in order to release a new image tag?

  3. Every PR merge will update the existing image and its taking existing image tag using this job Docker meta in release.yml. Is my understaning correct ?

  4. What scenario is the task Scheduled buildin schedule.yml being used in? is use a cron job to start the build process. is there any specific reason ? In case if we have't made any changes also this job gets triggered is my understanding correct ?

  5. Our current release 2.5.2 but Java Doc(https://hyperledger.github.io/fabric-chaincode-java/) and API (https://hyperledger.github.io/fabric-chaincode-java/release-2.2/api/)pointing to 2.2.4 . is there seprate process to update ?

@denyeart @bestbeforetoday

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the fabric-chaincode-shim:2.5.2 version needs to be changed fabric-chaincode-shim:2.5.3. Line No:24. I will create the separate PR that way i can understand process

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the fabric-chaincode-shim:2.5.2 version needs to be changed fabric-chaincode-shim:2.5.3. Line No:24. I will create tghe separate PR that way i can understand process

@bestbeforetoday
Copy link
Member Author

In examples we need to change the version from 2.5.2 to 2.5.3. I will create the separate PR that way i can understand process. Apart from this i have couple of question can you guys help me to clarify my question.

There is currently no v2.5.3 release. I deliberately left the examples pointing to the current (latest) v2.5.2 release so they can be used as working examples. Once a v2.5.3 release is created, the examples can be updated to point to that release, and all the other version references can be moved on to v2.5.4 to be used in snapshot builds and in preparation for the next release.

@benjsmi
Copy link
Contributor

benjsmi commented May 23, 2024

What scenario is the task Scheduled buildin schedule.yml being used in? is use a cron job to start the build process. is there any specific reason ? In case if we have't made any changes also this job gets triggered is my understanding correct ?

Your understanding is correct -- the build will run periodically with no action on our part

So just because we don't make changes doesn't mean nothing changes around us. Dependencies can move, scans can/could find new vulnerabilities, etc.

Running a build at some regular, hands-off interval is generally considered good CI/CD practice.

Copy link
Contributor

@MuthuSundaravadivel MuthuSundaravadivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Hence i am approving this PR

@bestbeforetoday bestbeforetoday merged commit 6615ebb into hyperledger:main May 23, 2024
@bestbeforetoday bestbeforetoday deleted the java-version branch May 23, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants