-
Notifications
You must be signed in to change notification settings - Fork 212
Restore Java 8 compatibility #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Java 8 compatibility #349
Conversation
fe3d9b7
to
f4da357
Compare
8fab94f
to
f5061d5
Compare
6daa8bd
to
7f195a5
Compare
Build with source and target bytecode compatibility for Java 8. This allows chaincode implementation code that requires Java 8 compatibility to compile against the fabric-chaincode-shim package. Avoid use of mavenLocal() and (deprecated) jcenter() Gradle repositories. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
7f195a5
to
3fdf130
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the fabric-chaincode-shim:2.5.2 version needs to be changed fabric-chaincode-shim:2.5.3. Line No:24. I will create the separate PR that way i can understand process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the fabric-chaincode-shim:2.5.2 version needs to be changed fabric-chaincode-shim:2.5.3 Line No 17. I will create the separate PR that way i can understand process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In examples we need to change the version from 2.5.2 to 2.5.3. I will create the separate PR that way i can understand process. Apart from this i have couple of question can you guys help me to clarify my question.
-
Does the vulnerability scan action check every dependency that the Java SDK uses?
-
The
ubuntu-latest
job is executed whenever a PR is merged, its handling the build, jar, and image pushes to the registry. How will the tagging take place? Do I need to rungit tag
in order to release a new image tag? -
Every PR merge will update the existing image and its taking existing image tag using this job
Docker meta
inrelease.yml
. Is my understaning correct ? -
What scenario is the task
Scheduled build
inschedule.yml
being used in? is use a cron job to start the build process. is there any specific reason ? In case if we have't made any changes also this job gets triggered is my understanding correct ? -
Our current release 2.5.2 but Java Doc(https://hyperledger.github.io/fabric-chaincode-java/) and API (https://hyperledger.github.io/fabric-chaincode-java/release-2.2/api/)pointing to 2.2.4 . is there seprate process to update ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the fabric-chaincode-shim:2.5.2 version needs to be changed fabric-chaincode-shim:2.5.3. Line No:24. I will create the separate PR that way i can understand process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the fabric-chaincode-shim:2.5.2 version needs to be changed fabric-chaincode-shim:2.5.3. Line No:24. I will create tghe separate PR that way i can understand process
There is currently no v2.5.3 release. I deliberately left the examples pointing to the current (latest) v2.5.2 release so they can be used as working examples. Once a v2.5.3 release is created, the examples can be updated to point to that release, and all the other version references can be moved on to v2.5.4 to be used in snapshot builds and in preparation for the next release. |
Your understanding is correct -- the build will run periodically with no action on our part So just because we don't make changes doesn't mean nothing changes around us. Dependencies can move, scans can/could find new vulnerabilities, etc. Running a build at some regular, hands-off interval is generally considered good CI/CD practice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good. Hence i am approving this PR
Build with source and target bytecode compatibility for Java 8. This allows chaincode implementation code that requires Java 8 compatibility to compile against the fabric-chaincode-shim package.
Avoid use of mavenLocal() and (deprecated) jcenter() Gradle repositories.