Fix callTracer missing revertReason and nested calls for reverted transactions #9651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR fixes two critical issues in Besu's
callTracerimplementation that caused incompatibility with Geth when tracing reverted transactions.Issue 1: Missing
revertReasonfield for reverted transactionsProblem:
When a transaction reverted with an Error(string) message, Besu's callTracer output included the ABI-encoded revert data in the
outputfield but wasmissing the decoded
revertReasonfield that Geth provides.Root Cause:
CallTracerErrorHandlerwas not decoding revert reasons from the output data.Fix:
revertReasonDecoded(String)method toCallTracerResult.Builderfor setting revertReason without hex fallbackCallTracerErrorHandler.handleRootError()andCallTracerErrorHandler.setOutputAndErrorStatus()to useJsonRpcErrorResponse.decodeRevertReason()revertReasonfield when the revert data is a valid Error(string) format (starts with 0x08c379a0), ensuring Geth compatibilityFiles Changed:
CallTracerResult.java- AddedrevertReasonDecoded()methodCallTracerErrorHandler.java- Added revert reason decoding logicIssue 2: Missing nested
callsarray when transaction revertsProblem:
When a transaction reverted, Besu's callTracer was not capturing nested calls at all. The
callsarray was completely missing from the output, eventhough Geth includes all nested calls up to the point of revert.
Root Cause:
CallTracerResultConverter.buildCallHierarchyFromFrames()had an early return that prevented frame processing for ALL unsuccessful transactions,including reverts.
Fix:
callsarrayFiles Changed:
CallTracerResultConverter.java- Updated condition inbuildCallHierarchyFromFrames()Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests