-
Notifications
You must be signed in to change notification settings - Fork 1k
[deps] [gradle] Locking Dependencies #9603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Signed-off-by: Matthew Whitehead <matthew.whitehead@kaleido.io>
Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io>
matthew1001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but @jflo I think you (or someone else) might want to take a look as well?
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
|
Tests failed due to a bunch of 403's from Maven - assuming thats a blip |
fab-10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the lockfile be added also for the evmtool? and could you link the doc of how Trivy uses this?
| <sha256 value="b67cc3d0980927049a3beb00d506ece288746732b0dec812245c59f453fb1ca1" origin="Generated by Gradle"/> | ||
| </artifact> | ||
| </component> | ||
| <component group="org.apache.logging.log4j" name="log4j-api" version="2.25.2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why these additions? I do not see changes in the dependency list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this was likely from an unclean Gradle state - lemme fix that.
Definitely, we've realized w/ kaleido-io#32 we're missing a ton of lockfiles frankly - so will move this to draft and better explain how to generate the lockfiles reliably and how they are used by |
PR description
gradle.lockfile, similar to thegradle/verification-metadata.xml, helps to make builds reproducible and ensures always the same versions are installed, with the verification metadata ensuring those versions are still the same as when they were originally installed/tested.The lockfile is useful for tools like
trivy(which is used for image scanning currently in the Besu GHA workflows) to be able to generate an SBOM w/o having to first compile the software into JARs.cc @matthew1001
Fixed Issue(s)
N/A
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests