Updated SimpleNodePermissioning smart contract to relax enodeURL matc… #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hing to exclude the p2p port. Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
macfarla
reviewed
May 19, 2020
acceptance-tests/tests/simple-permissioning-smart-contract/test/test-node-permissioning.js
Show resolved
Hide resolved
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
macfarla
approved these changes
May 19, 2020
macfarla
approved these changes
May 20, 2020
acceptance-tests/tests/src/test/resources/permissioning/simple_permissioning_genesis.json
Show resolved
Hide resolved
acceptance-tests/tests/simple-permissioning-smart-contract/test/test-node-permissioning.js
Show resolved
Hide resolved
shemnon
pushed a commit
to shemnon/besu
that referenced
this pull request
May 23, 2020
hyperledger#945) Updated SimpleNodePermissioning smart contract in the acceptance tests to relax enodeURL matching to exclude the p2p port. Signed-off-by: Mark Terry <mark.terry@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jun 3, 2020
hyperledger#945) Updated SimpleNodePermissioning smart contract in the acceptance tests to relax enodeURL matching to exclude the p2p port. Signed-off-by: Mark Terry <mark.terry@consensys.net> Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hing to exclude the p2p port.
Signed-off-by: Mark Terry mark.terry@consensys.net
PR description
Relaxes the enodeURL matching function in the SimpleNodePermissioning smart contract to allow matches where the p2p port has changed. This addresses an issue in the Acceptance Tests where the port is dynamic and thus will not be permitted after a restart.
Fixed Issue(s)
Fixes #907.