Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose price bump to a CLI flag. #930

Merged
merged 4 commits into from
May 15, 2020
Merged

Expose price bump to a CLI flag. #930

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed08b7e
Expose price bump to a CLI flag.
AbdelStark May 15, 2020
a15e5e2
Added unit test
AbdelStark May 15, 2020
c60115a
Fixed unit test
AbdelStark May 15, 2020
0d04666
Removed SuppressWarnings annotation
AbdelStark May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed SuppressWarnings annotation 
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
  • Loading branch information
@AbdelStark
AbdelStark committed May 15, 2020
commit 0d0466601f4668aedfa8f547912107f0a92d6187
3 changes: 1 addition & 2 deletions besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,15 +898,14 @@ void setBannedNodeIds(final List<String> values) {
private final Integer pendingTxRetentionPeriod =
TransactionPoolConfiguration.DEFAULT_TX_RETENTION_HOURS;

@SuppressWarnings({"FieldCanBeFinal", "FieldMayBeFinal"}) // PicoCLI requires non-final.
@Option(
names = {"--tx-pool-price-bump"},
matkt marked this conversation as resolved.
Show resolved Hide resolved
paramLabel = MANDATORY_INTEGER_FORMAT_HELP,
converter = PercentageConverter.class,
description =
"Price bump percentage to replace an already existing transaction (default: ${DEFAULT-VALUE})",
arity = "1")
private Integer priceBump = TransactionPoolConfiguration.DEFAULT_PRICE_BUMP.getValue();
private final Integer priceBump = TransactionPoolConfiguration.DEFAULT_PRICE_BUMP.getValue();

@SuppressWarnings({"FieldCanBeFinal", "FieldMayBeFinal"}) // PicoCLI requires non-final Strings.
@Option(
Expand Down