-
Notifications
You must be signed in to change notification settings - Fork 1k
Allow for report interval customization through CLI #9271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
macfarla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a suggestion re type of CLI param - you'll see elsewhere in the codebase Boxed types are used rather than primitives for CLI options
app/src/main/java/org/hyperledger/besu/cli/options/EthstatsOptions.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/hyperledger/besu/cli/options/EthstatsOptions.java
Outdated
Show resolved
Hide resolved
|
Ok, I've made the change from primitive to boxed type. |
ethereum/ethstats/src/test/java/org/hyperledger/besu/ethstats/EthStatsServiceTest.java
Show resolved
Hide resolved
macfarla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spotless check is failing
|
I ran |
|
@dhvogel spotless is still failing |
|
|
|
running |
834002d to
f01699a
Compare
Signed-off-by: Dan Vogel <dhvogel2468@gmail.com>
Signed-off-by: Dan Vogel <dhvogel2468@gmail.com> Signed-off-by: jflo <justin+github@florentine.us>
PR description
This PR fixes #9270, allowing for customizable ethstats report intervals, which are needed by other blockchains like Linea to keep pace with faster block times than Ethereum Mainnet (see #9269).
Fixed Issue(s)
Fixes #9270
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required. (I think probably not, because the CLI contains documentation, but let me know if otherwise)Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests