[EIP-1559] Transaction pool pricing rules must handle both frontier and EIP-1559 transactions. #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the local pool using eth_sendRawTransaction JSON RPC endpoint. Transaction price must be computed properly depending on the type of the transaction. For instance `shouldReplace` method of PendingTransactions must be updated to deal with EIP-1559 transactions. - Updated `PendingTransactions` to add access to the chain header in order to retrieve the last base fee value. - Updated `TransactionReplacementByPriceRule` to compute the transaction price depending on the type of the transaction (frontier or eip-1559). - Added unit tests to cover all possible replacement scenarios. Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
shemnon
pushed a commit
to shemnon/besu
that referenced
this pull request
May 23, 2020
…nd EIP-1559 transactions. (hyperledger#919) * The transaction gas price is computed when adding a transaction into the local pool using eth_sendRawTransaction JSON RPC endpoint. Transaction price must be computed properly depending on the type of the transaction. For instance `shouldReplace` method of PendingTransactions must be updated to deal with EIP-1559 transactions. - Updated `PendingTransactions` to add access to the chain header in order to retrieve the last base fee value. - Updated `TransactionReplacementByPriceRule` to compute the transaction price depending on the type of the transaction (frontier or eip-1559). - Added unit tests to cover all possible replacement scenarios. Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jun 3, 2020
…nd EIP-1559 transactions. (hyperledger#919) * The transaction gas price is computed when adding a transaction into the local pool using eth_sendRawTransaction JSON RPC endpoint. Transaction price must be computed properly depending on the type of the transaction. For instance `shouldReplace` method of PendingTransactions must be updated to deal with EIP-1559 transactions. - Updated `PendingTransactions` to add access to the chain header in order to retrieve the last base fee value. - Updated `TransactionReplacementByPriceRule` to compute the transaction price depending on the type of the transaction (frontier or eip-1559). - Added unit tests to cover all possible replacement scenarios. Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net> Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The transaction gas price is computed when adding a transaction into the local pool using
eth_sendRawTransactionJSON RPC endpoint. Transaction price must be computed properly depending on the type of the transaction.For instance
shouldReplacemethod of PendingTransactions must be updated to deal with EIP-1559 transactions.PendingTransactionsto add access to the chain header in order to retrieve the last base fee value.TransactionReplacementByPriceRuleto compute the transaction price depending on the type of the transaction (frontier or eip-1559).Issues
fixes #905
Signed-off-by: Abdelhamid Bakhta abdelhamid.bakhta@consensys.net