Add support for private log subscriptions (Pub-Sub API) #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassaldanha
changed the title
RatanRSur
reviewed
May 6, 2020
...src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/websocket/methods/PrivSubscribe.java
Show resolved
Hide resolved
...perledger/besu/ethereum/api/jsonrpc/websocket/subscription/logs/LogsSubscriptionService.java
Show resolved
Hide resolved
lucassaldanha
commented
May 8, 2020
pinges
reviewed
May 8, 2020
| final SubscriptionManager subscriptionManager, | ||
| final PrivacyParameters privacyParameters) { | ||
|
|
||
| Optional<PrivacyQueries> privacyQueries = Optional.empty(); |
There was a problem hiding this comment.
could do an if/else or even
privacyQueries = privacyParameters.isEnabled() ? x : y;
There was a problem hiding this comment.
I think the way that it is implemented makes it more readable. PrivacyQueries start empty and, if privacy is enabled, we set it to the proper object.
I think in this case the ternary operator will make it less readable.
.../src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/response/JsonRpcError.java
Outdated
Show resolved
Hide resolved
| public Collection<JsonRpcMethod> methods() { | ||
| final SubscriptionRequestMapper subscriptionRequestMapper = new SubscriptionRequestMapper(); | ||
| final EnclavePublicKeyProvider enclavePublicKeyProvider = | ||
| EnclavePublicKeyProvider.build(privacyParameters); |
There was a problem hiding this comment.
We do this in the PrivacyApiGroupJsonRpcMethods as well, but in the PrivJsonRpcMethods we do pass the privacy controller and the enclavePublicKeyProvider into the create() method.
This means that we have several instances of the controller and enclavePKP where we would only need one.
Can we fix that in a nice way?
...dger/besu/ethereum/api/jsonrpc/websocket/subscription/request/SubscriptionRequestMapper.java
Outdated
Show resolved
Hide resolved
...er/besu/ethereum/api/jsonrpc/websocket/subscription/response/SubscriptionResponseResult.java
Show resolved
Hide resolved
pinges
approved these changes
May 11, 2020
...test/java/org/hyperledger/besu/ethereum/api/jsonrpc/websocket/methods/PrivSubscribeTest.java
Show resolved
Hide resolved
...test/java/org/hyperledger/besu/ethereum/api/jsonrpc/websocket/methods/PrivSubscribeTest.java
Show resolved
Hide resolved
...test/java/org/hyperledger/besu/ethereum/api/jsonrpc/websocket/methods/PrivSubscribeTest.java
Show resolved
Hide resolved
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
• Created the two private subscription-related methods (priv_subscribe/priv_unsubscribe)
• Created a new type of subscription
PrivateLogsSubscription• Updated
LogsSubscriptionServiceto observe new blocks and check for private logs (similar to what is done in theFilterManager).• Updated
WebSocketRequestHandlerto deal withInvalidJsonRpcParametersexception• Some plumbing work to get everything working together!
Fixed Issue(s)
fixes #762