Skip to content

Conversation

macfarla
Copy link
Contributor

PR description

Block importer was previously advancing the head for the world state by default.

This method is only used by backward sync context and rlp block importer. It works directly on the head world state.

This PR introduces a check so that the worldstate only updates head if the block processing (import) was successful. This then matches how the scenario would play out when driven by the Engine API.

Fixed Issue(s)

This fixes a hive test that uses RLPBlockImporter to set up a specific scenario checkGasLimit_Cancun

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit a611b3b into hyperledger:main Mar 21, 2025
43 checks passed
@macfarla macfarla deleted the hive-cancun-gaslimit branch March 23, 2025 23:21
@macfarla macfarla added the hive relating to hive tests label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bonsai hive relating to hive tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants