Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all invalid transient not selected txs should be penalized #8231

Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Feb 3, 2025

PR description

Until now, ff a pending tx is not selected during block creation, with a transient invalid reason, it was kept in the txpool, but was always penalized and this is not always correct, since there are some invalid reasons that are independent from the pending tx, for example in case of not enough remaining gas in the block, or because a previous pending txs from the same sender was not selected.

This PR differentiate transient reason for not selecting a pending txs, between penalizing and not, with the introduction of TransactionSelectionResult::invalidPenalized when we want to penalize the pending tx and keeping TransactionSelectionResult.invalidTransient for when we do not want to penalize.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 marked this pull request as ready for review February 3, 2025 16:06
@fab-10 fab-10 enabled auto-merge (squash) February 4, 2025 09:25
@fab-10 fab-10 merged commit 90df5e5 into hyperledger:main Feb 4, 2025
43 checks passed
pullurib pushed a commit to pullurib/besu that referenced this pull request Feb 6, 2025
…ledger#8231)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants