Remove references and logic of system property besu.docker #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
…perty Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
…perty Signed-off-by: Usman Saleem <usman@usmans.info>
…perty Signed-off-by: Usman Saleem <usman@usmans.info>
…perty Signed-off-by: Usman Saleem <usman@usmans.info>
jframe
approved these changes
Apr 30, 2020
| @@ -1960,42 +1954,19 @@ private String genesisConfig() { | |||
| } | |||
|
|
|||
| private File genesisFile() { | |||
There was a problem hiding this comment.
Doesn't seem to be much benefit in wrapping this in a function
| } else { | ||
| return getDefaultBesuDataPath(this); | ||
| } | ||
| return standaloneCommands.dataPath.toAbsolutePath(); |
There was a problem hiding this comment.
Same as above, think we can inline this function where it is needed
shemnon
reviewed
May 1, 2020
| @@ -991,9 +986,7 @@ void setBesuConfiguration(final BesuConfiguration pluginCommonConfiguration) { | |||
|
|
|||
| private BesuCommand handleStandaloneCommand() { | |||
| standaloneCommands = new StandaloneCommand(); | |||
There was a problem hiding this comment.
Is folding StandaloneCommand back into Besu Command part of this PR or a follow on PR?
There was a problem hiding this comment.
I missed that bit, I've added it into same PR.
…perty Signed-off-by: Usman Saleem <usman@usmans.info>
…k into BesuCommand Signed-off-by: Usman Saleem <usman@usmans.info>
…perty Signed-off-by: Usman Saleem <usman@usmans.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
BesuCommand class (and related unit tests) has quite a bit of deprecated logic which sets various defaults depending on if system property besu.docker is present or not. However, this property is not set in Besu's docker file anymore. Hence, the relevant code needs to be removed.
Fixed Issue(s)
#785
Signed-off-by: Usman Saleem <usman@usmans.info>