Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onchain permissioning deprecation warnings on CLI #7902

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

macfarla
Copy link
Contributor

PR description

  • Add deprecation messages to help descriptions
  • Add warning log if permissioning-*-contract-enabled option is specified

Note I did not add any @Deprecation annotations to types or methods - feedback welcome on whether you think this is needed.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10
Copy link
Contributor

fab-10 commented Nov 26, 2024

I think the @Deprecation is useful if the type or method is public and can be used by third party like in the plugin API

@macfarla
Copy link
Contributor Author

I think the @Deprecation is useful if the type or method is public and can be used by third party like in the plugin API

yeah I went with adding it to API methods and plugins

@macfarla macfarla enabled auto-merge (squash) November 27, 2024 01:44
@macfarla macfarla merged commit 58fbbe3 into hyperledger:main Nov 27, 2024
43 checks passed
@macfarla macfarla deleted the permissioning-onchain-dep branch December 5, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants