Skip to content

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Nov 21, 2024

PR description

  • Add deprecation messages to help descriptions
  • Add warning log if privacy-enabled option is specified

Note I did not add any @Deprecation annotations to types or methods - feedback welcome on whether you think this is needed.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - don't think we need deprecation warnings on methods or classes

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Copy link
Contributor Author

After a conversation with @jflo I added Deprecation annotations to the privacy plugin classes since there is active ongoing development with plugins generally

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla enabled auto-merge (squash) November 22, 2024 01:36
@macfarla macfarla merged commit 302999a into hyperledger:main Nov 22, 2024
43 checks passed
@macfarla macfarla deleted the privacy-deprecation-annotations branch December 5, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants