Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:Removed Dupicate AcceptanceTestBase #7815

Merged

Conversation

pr9t
Copy link
Contributor

@pr9t pr9t commented Oct 26, 2024

PR description

Removed Duplicate AcceptanceTestBase class

Fixed Issue(s)

fixes #7348

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

pr9t and others added 3 commits October 26, 2024 19:14
Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @pr9t

@macfarla macfarla enabled auto-merge (squash) October 27, 2024 23:41
@macfarla macfarla merged commit 8ed4a90 into hyperledger:main Oct 28, 2024
43 checks passed
JanetMo pushed a commit to JanetMo/besu that referenced this pull request Nov 17, 2024
* chore:Removed Dupicate AcceptanceTestBase

Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>

* formatting

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the duplicated AcceptanceTestBase
2 participants