Chore:Resolved java Util NoSuchElementException #7730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Preeti <35308865+pr9t@users.noreply.github.com>
macfarla
reviewed
Oct 8, 2024
| .collect(Collectors.toList())) | ||
| .map(this::txReceipt) | ||
| .flatMap(Optional::stream) | ||
| .collect(Collectors.toList())) |
There was a problem hiding this comment.
can you add a test for the issue that this change is solving?
There was a problem hiding this comment.
Hi Macfarla, I actually don't know how to create tests. I am new to Java and currently learning. Can you please guide me?
There was a problem hiding this comment.
Have a look at EthGetBlockReceiptsTest - however on reflection I think it would need a fair amount of refactoring to add a test for this so I'm happy to merge as is.
There was a problem hiding this comment.
Hi @macfarla,
I have run the EthGetBlockReceiptsTest, and it is passing. If you want me to run another test, please let me know the details.
macfarla
approved these changes
Oct 10, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Resolved java.util.NoSuchElementException: No value present, processing method: eth_getBlockReceipts.
Fixed Issue(s)
fixes #7635
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests