Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eip-2537 functions to evmtool benchmark subcommand #7708

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Oct 2, 2024

PR description

Add Bls precompiles to the evmtool benchmark subcommand

run with evmtool --fork=prague benchmark bls12

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

gradle.properties Outdated Show resolved Hide resolved
@garyschulte garyschulte force-pushed the benchmarkz branch 2 times, most recently from ce652f2 to dcccad5 Compare October 11, 2024 01:06
@garyschulte garyschulte marked this pull request as ready for review October 11, 2024 01:06
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, minor comment about logging and potential cruft

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte enabled auto-merge (squash) October 11, 2024 15:36
@garyschulte garyschulte merged commit 6c49c73 into hyperledger:main Oct 11, 2024
43 checks passed
@garyschulte garyschulte deleted the benchmarkz branch October 11, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants