Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JsonRpcResponseType to RpcResponseType in the plugin API module #7392

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Jul 29, 2024

PR description

This PR has is preparatory for PR #7379, to make the latter easier to review, there are no functional changes here, but just the move JsonRpcResponseType to RpcResponseType in the plugin API module.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fab-10 fab-10 merged commit ab77523 into hyperledger:main Jul 29, 2024
40 checks passed
@fab-10 fab-10 deleted the in-process-rpc-service-pre-1 branch July 29, 2024 11:42
gconnect pushed a commit to gconnect/besu that referenced this pull request Aug 26, 2024
…ule (hyperledger#7392)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: gconnect <agatevureglory@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants