Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and restore disabled block creation unit tests #7331

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Jul 16, 2024

PR description

Disabled block creation unit tests have been updated and fixed and re-enabled, this required to rework the ExecutionContextTestFixture to accept the genesis file to use, instead of using an hard-coded one as before, and for this there are more file changed/added

Fixed Issue(s)

fixes #6850

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the restore-block-creation-tests branch from 193bd49 to 475fb5a Compare July 16, 2024 10:39
@fab-10 fab-10 marked this pull request as ready for review July 16, 2024 10:39
@fab-10 fab-10 enabled auto-merge (squash) July 16, 2024 10:41
@fab-10 fab-10 merged commit 465fd1c into hyperledger:main Jul 16, 2024
40 checks passed
@fab-10 fab-10 deleted the restore-block-creation-tests branch July 17, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test - LegacyFeeMarketBlockTransactionSelectorTest
2 participants