Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release checklist #7329

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Jul 16, 2024

Takes into account latest changes from @cdivitotawela

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu requested a review from jflo July 16, 2024 07:35
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a GHA for homebrew release now

- [ ] Publish Docs Release
- [ ] Check binary SHAs are correct on the release page
- [ ] Check "Container Verify" GitHub workflow has run successfully
- [ ] Create homebrew PR - run https://github.com/hyperledger/homebrew-besu/blob/main/updateBesu.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] Create homebrew PR - run https://github.com/hyperledger/homebrew-besu/blob/main/updateBesu.sh
- [ ] Create homebrew release - run https://github.com/hyperledger/homebrew-besu/actions/workflows/update-version.yml

@siladu siladu marked this pull request as draft July 17, 2024 00:39
@siladu
Copy link
Contributor Author

siladu commented Jul 17, 2024

On pause as there is an incoming change to besu-docs release workflow as well.

siladu added 2 commits July 18, 2024 12:12
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu marked this pull request as ready for review July 18, 2024 02:13
@siladu siladu requested a review from cdivitotawela July 18, 2024 02:13
Copy link
Contributor

@cdivitotawela cdivitotawela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

siladu added 2 commits July 18, 2024 13:44
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu enabled auto-merge (squash) July 18, 2024 03:48
@siladu siladu merged commit 592acb7 into hyperledger:main Jul 18, 2024
40 checks passed
@siladu siladu deleted the release-checklist-update branch July 18, 2024 04:13
gconnect pushed a commit to gconnect/besu that referenced this pull request Aug 26, 2024
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: gconnect <agatevureglory@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants