Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude permissioning test from default ATs run on PRs #7327

Merged
merged 10 commits into from
Jul 18, 2024
Merged

exclude permissioning test from default ATs run on PRs #7327

merged 10 commits into from
Jul 18, 2024

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Jul 16, 2024 •
edited
Loading

PR description

Rather than disabling permissioning tests one by one as they flake, exclude them from being run on PRs.

Could run the permissioning suite on a nightly/weekly cadence instead

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla
exclude permissioning test from default ATs run on PRs
7cb4670 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla added flake 60% of the time it works 100% of the time. testing labels Jul 16, 2024
@macfarla macfarla mentioned this pull request Jul 16, 2024
Closed
8 tasks
jframe
jframe approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla
Copy link
Contributor Author 

2024-07-17T02:40:16.5513126Z 2: Task failed with an exception.
2024-07-17T02:40:16.5513749Z -----------
2024-07-17T02:40:16.5514112Z * What went wrong:
2024-07-17T02:40:16.5514972Z Execution failed for task ':acceptance-tests:tests:shanghai:compileSolidity'.
2024-07-17T02:40:16.5515959Z > java.net.ConnectException: Connection timed out

@macfarla macfarla merged commit 3925ee4 into hyperledger:main Jul 18, 2024
40 checks passed
This was referenced Jul 18, 2024
Closed
Closed
Closed
gconnect pushed a commit to gconnect/besu that referenced this pull request Aug 26, 2024
@macfarla @gconnect
exclude permissioning test from default ATs run on PRs (hyperledger#7327
d558f50 
)

* exclude permissioning test from default ATs run on PRs

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: gconnect <agatevureglory@gmail.com>
@macfarla macfarla deleted the ats-exclude-permissioning branch October 21, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
flake 60% of the time it works 100% of the time. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @jframe