Fix support of peers that do not support eth/65 #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
atoulme
changed the title
atoulme
changed the title
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
shemnon
reviewed
Apr 15, 2020
.../main/java/org/hyperledger/besu/ethereum/eth/transactions/PeerPendingTransactionTracker.java
Outdated
Show resolved
Hide resolved
shemnon
reviewed
Apr 15, 2020
.../main/java/org/hyperledger/besu/ethereum/eth/transactions/PeerPendingTransactionTracker.java
Outdated
Show resolved
Hide resolved
shemnon
reviewed
Apr 15, 2020
...h/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/PendingTransactionSender.java
Outdated
Show resolved
Hide resolved
…ransactions/PeerPendingTransactionTracker.java Co-Authored-By: Danno Ferrin <danno.ferrin@shemnon.com> Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
shemnon
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antoine Toulme antoine@lunar-ocean.com
PR description
Make sure to not enroll peers that do not support eth/65 for sending pending transactions, as the client will otherwise throw an error when negotiating sending the message to the peer.
Fixed Issue(s)
Fixes #723