Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck #715

Merged
merged 5 commits into from
Apr 19, 2020
Merged

Healthcheck #715

merged 5 commits into from
Apr 19, 2020

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Apr 15, 2020

PR description

This PR adds a healthcheck to the Docker image shipped by default with Besu.

The healthcheck itself consists in checking that Besu has written a file to a specific path.
The file contains the PID of the process.
The file is deleted if the process exits normally. The program does not attempt to try to clean up the file if the process exits abnormally.

atoulme added 4 commits April 14, 2020 23:35
…althcheck

Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Copy link
Contributor

@EdJoJob EdJoJob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would prefer someone with more recent Java experience to check the style and idioms being used.

Copy link
Contributor

@joshuafernandes joshuafernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme atoulme merged commit 1d49359 into hyperledger:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants