Wire EIP-2935 into evmtool #7096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cover one missed case where the BlockHashLookup changes in the EIP-2935 handling, ensureing the `state-test` tool gets proper prague handling. Signed-off-by: Danno Ferrin <danno@numisight.com>
|
fixes holiman/goevmlab#146 |
Cover one missed case where the BlockHashLookup changes in the EIP-2935 handling, ensureing the `state-test` tool gets proper prague handling. Signed-off-by: Danno Ferrin <danno@numisight.com>
|
there's a test failure -
EvmToolSpecTests > testBySpec(String, JsonNode, JsonNode, JsonNode) > t8n/shanghai-blockhash.json FAILED |
Signed-off-by: Danno Ferrin <danno@numisight.com>
holiman
reviewed
May 15, 2024
| blockHashLookup = | ||
| (messageFrame, number) -> { | ||
| long lookback = messageFrame.getBlockValues().getNumber() - number; | ||
| if (lookback < 0 || lookback > BlockHashOperation.MAX_RELATIVE_BLOCK) { |
There was a problem hiding this comment.
SHould be lookback <= 0, probably. Because that means the messageframe blocknumber is the same as the one requested: BLOCKHASH(this block).
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
May 28, 2024
Cover one missed case where the BlockHashLookup changes in the EIP-2935 handling, ensureing the `state-test` tool gets proper prague handling. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
Cover one missed case where the BlockHashLookup changes in the EIP-2935 handling, ensureing the `state-test` tool gets proper prague handling. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Danno Ferrin <danno@numisight.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jun 10, 2024
Cover one missed case where the BlockHashLookup changes in the EIP-2935 handling, ensureing the `state-test` tool gets proper prague handling. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Cover one missed case where the BlockHashLookup changes in the EIP-2935
handling, ensuring the
state-testtool gets proper prague handling.Signed-off-by: Danno Ferrin danno@numisight.com
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests