do not use NO_PROXY_CACHE env variable with apt-get install to avoid a linting error #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a linting error Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
fab-10
approved these changes
May 8, 2024
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
May 28, 2024
…a linting error (hyperledger#7077) Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
…a linting error (hyperledger#7077) Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jun 10, 2024
…a linting error (hyperledger#7077) Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
A recent modification in the Dockerfiles triggers a linting error which fails the pipeline running on the
mainbranch. Ignoring the rule seems a bad idea, because it is enforcing that all packages which are installed via apt-get have a defined version number, which is a best practice.Instead I have opted for replacing the ENV variable which triggers the error with the respective string.
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests