Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

javadoc - Adding default constructor and javadoc for :plugin-api #7072

Merged
merged 2 commits into from
May 8, 2024
Merged

javadoc - Adding default constructor and javadoc for :plugin-api #7072

merged 2 commits into from
May 8, 2024

Conversation

usmansaleem
Copy link
Member

PR description

javadoc - Adding default constructor and javadoc for :plugin-api

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@usmansaleem
javadoc - Adding default constructor and javadoc for :plugin-api
4dba8f9 
Signed-off-by: Usman Saleem <usman@usmans.info>
@usmansaleem usmansaleem requested a review from macfarla May 8, 2024 02:29
@usmansaleem usmansaleem self-assigned this May 8, 2024
@usmansaleem usmansaleem enabled auto-merge (squash) May 8, 2024 05:23
@usmansaleem usmansaleem merged commit 8c596a5 into hyperledger:main May 8, 2024
42 checks passed
@usmansaleem usmansaleem deleted the fix_javadoc_java21_7 branch May 8, 2024 06:16
jflo pushed a commit to jflo/besu that referenced this pull request May 28, 2024
@usmansaleem @jflo
javadoc - Adding default constructor and javadoc for :plugin-api (hyp…
9fe7cb8 
…erledger#7072)

Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
@usmansaleem @matthew1001
javadoc - Adding default constructor and javadoc for :plugin-api (hyp…
a8845a4 
…erledger#7072)

Signed-off-by: Usman Saleem <usman@usmans.info>
jflo pushed a commit to jflo/besu that referenced this pull request Jun 10, 2024
@usmansaleem @jflo
javadoc - Adding default constructor and javadoc for :plugin-api (hyp…
1c26167 
…erledger#7072)

Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees

@usmansaleem usmansaleem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usmansaleem @macfarla