Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some typos in comments #7005

Merged
merged 2 commits into from
Apr 30, 2024
Merged

chore: fix some typos in comments #7005

merged 2 commits into from
Apr 30, 2024

Conversation

knowmost
Copy link
Contributor

@knowmost knowmost commented Apr 28, 2024 •
edited
Loading

PR description

fix some typos in comments

Fixed Issue(s)

fix some typos in comments

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@knowmost
chore: fix some typos in comments
e96f334 
Signed-off-by: knowmost <knowmost@outlook.com>
@macfarla macfarla merged commit eb6c349 into hyperledger:main Apr 30, 2024
42 checks passed
jflo pushed a commit to jflo/besu that referenced this pull request May 28, 2024
@knowmost @macfarla @jflo
chore: fix some typos in comments (hyperledger#7005)
8ee4495 
Signed-off-by: knowmost <knowmost@outlook.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
@knowmost @macfarla @matthew1001
chore: fix some typos in comments (hyperledger#7005)
6f3f525 
Signed-off-by: knowmost <knowmost@outlook.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo pushed a commit to jflo/besu that referenced this pull request Jun 10, 2024
@knowmost @macfarla @jflo
chore: fix some typos in comments (hyperledger#7005)
e1c97b0 
Signed-off-by: knowmost <knowmost@outlook.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knowmost @macfarla