Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BESU-531] Implement fallback method for Nat #692

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Apr 9, 2020

Signed-off-by: Karim TAAM karim.t2am@gmail.com

PR description

Implementation of a fallback if the initialization of the NatManager fails (for example bad configuration of a kubernetes). In case of failure the NONE Mode is used

shemnon and others added 6 commits April 8, 2020 10:37
When we deny a connection based on HTTP hostname log to trace the
rejected value.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Co-authored-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
…besu-531-implement-fallback-method-for-nat

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AbdelStark AbdelStark merged commit 5655084 into hyperledger:master Apr 9, 2020
@matkt matkt deleted the feature/besu-531-implement-fallback-method-for-nat branch April 24, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants