Fix to increment/decrement gas-limit in block production #6425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
non-fungible-nelson
changed the title
Signed-off-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com>
Signed-off-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com>
Signed-off-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com>
Signed-off-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com>
Signed-off-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com>
non-fungible-nelson
force-pushed
the
nelson-gas-limit-fix
branch
from
1b7a6e9 to
b44019a
Compare
Signed-off-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com>
|
Think this is the geth code and it doesn't include a constant 1024 increment so besu does appear to be wrong according to both the spec and geth...https://github.com/ethereum/go-ethereum/blob/e5d5e09faae48dac3723634e2b1813e4f2e89535/core/block_validator.go#L152 |
pinges
reviewed
Jan 18, 2024
Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com>
…imit of 1024 Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
garyschulte
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
As long as we verified the arithmetic and the resulting diff in the test artifact, 🚢
currentGasLimit = 3141592 (0x2fefd8) |
macfarla
reviewed
Jan 18, 2024
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
|
Added same unit tests as geth for extra robustness https://github.com/ethereum/go-ethereum/blob/830f3c764c21f0d314ae0f7e60d6dd581dc540ce/core/block_validator_test.go#L242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixes discord bug found by protoplanetary
Fixed Issue(s)