Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTAINERS] New maintainer candidate: Karim Taam #640

Merged

Conversation

NicolasMassart
Copy link
Contributor

I propose to add Karim as a Besu project maintainer.

Karim contributed with many high quality commits (including Pegasys bounties):

  • NAT API and default implementation as well as Docker and Kubernetes ones,
  • log filters,
  • fast sync,
  • tracing.

Here are his past contributions on Besu project, and he even did some before the client was renamed to Besu.

Voting ends two weeks from today at midnight UTC on 2020-04-17

For more information on this process see the Becoming a Maintainer section in the MAINTAINERS.md file.

NOTE: new line added at the end of markdown file for standard compliance.

Karim contributed with many high quality commits (including bounties):
- NAT,
- log filters,
- fast sync,
- tracing.

Here are [his past contributions on Besu project]
(https://github.com/hyperledger/besu/commits?author=matkt)
and he even did some before the client was renamed to Besu.

Voting ends two weeks from today at
[midnight UTC on 2020-04-17](https://bit.ly/2JzWqd4)

For more information on this process see the
Becoming a Maintainer section in the MAINTAINERS.md file.

Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
@NicolasMassart NicolasMassart requested review from EdJoJob, edwardmack and a team and removed request for EdJoJob and edwardmack April 2, 2020 11:51
@NicolasMassart NicolasMassart self-assigned this Apr 2, 2020
Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@timbeiko timbeiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Karim has done significant contributions to Besu by adding support for UPNP & NAT, improving tracing APIs and more. Strongly support this :-)

Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended.

@NicolasMassart
Copy link
Contributor Author

By creating this PR, I approve Karim as a new maintainer.

@timbeiko timbeiko added this to the Chupacabra Sprint 62 milestone Apr 8, 2020
@NicolasMassart NicolasMassart merged commit 376112b into hyperledger:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.