Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the high spec flag #6354

Merged
merged 11 commits into from
Jan 24, 2024
Merged

Improve the high spec flag #6354

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2b53385
Improve the high spec flag, limit it to few column families
ahamlat Jan 5, 2024
0081a0d
Update changelog
ahamlat Jan 5, 2024
b6966ea
Fix unit tests
ahamlat Jan 5, 2024
5363ec2
spotless
ahamlat Jan 5, 2024
6e1990c
Update the plugin API hash as one of the interfaces was changed
ahamlat Jan 5, 2024
e60850e
Fix failing unit tests
ahamlat Jan 8, 2024
c420f1a
Update CHANGELOG.md
ahamlat Jan 15, 2024
bd60e06
Delete changes done to the memtables configuration
ahamlat Jan 22, 2024
5436deb
Merge remote-tracking branch 'origin/improve-high-spec-flag' into imp…
ahamlat Jan 22, 2024
2998f70
Merge branch 'main' into improve-high-spec-flag
ahamlat Jan 24, 2024
7f1422b
New API plugin hash
ahamlat Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
spotless 
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
  • Loading branch information
@ahamlat
ahamlat committed Jan 5, 2024
commit 5363ec2cb652090c3d2e914f4b4cbfb38f0bf397
4 changes: 2 additions & 2 deletions ...ledger/besu/plugin/services/storage/rocksdb/segmented/RocksDBColumnarKeyValueStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

import static java.util.stream.Collectors.toUnmodifiableSet;

import org.hyperledger.besu.ethereum.storage.keyvalue.KeyValueSegmentIdentifier;
import org.hyperledger.besu.plugin.services.MetricsSystem;
import org.hyperledger.besu.plugin.services.exception.StorageException;
import org.hyperledger.besu.plugin.services.metrics.OperationTimer;
Expand Down Expand Up @@ -213,7 +212,8 @@ private ColumnFamilyDescriptor createColumnDescriptor(
* @param config RocksDB configuration
* @return Block Base Table configuration
*/
private BlockBasedTableConfig createBlockBasedTableConfig(final SegmentIdentifier segment, final RocksDBConfiguration config) {
private BlockBasedTableConfig createBlockBasedTableConfig(
final SegmentIdentifier segment, final RocksDBConfiguration config) {
final LRUCache cache =
new LRUCache(
config.isHighSpec() && segment.isEligibleToHighSpecFlag()
Expand Down
5 changes: 2 additions & 3 deletions ...er/besu/plugin/services/storage/rocksdb/segmented/RocksDBColumnarKeyValueStorageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,8 @@ public enum TestSegment implements SegmentIdentifier {
this(id, false, false);
}

TestSegment(final byte[] id, final boolean containsStaticData, final boolean eligibleToHighSpecFlag) {
TestSegment(
final byte[] id, final boolean containsStaticData, final boolean eligibleToHighSpecFlag) {
this.id = id;
this.nameAsUtf8 = new String(id, StandardCharsets.UTF_8);
this.containsStaticData = containsStaticData;
Expand All @@ -384,8 +385,6 @@ public boolean containsStaticData() {
public boolean isEligibleToHighSpecFlag() {
return eligibleToHighSpecFlag;
}


}

protected abstract SegmentedKeyValueStorage createSegmentedStore() throws Exception;
Expand Down
Loading