Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate BFT tests to junit 5 #6350

Merged
merged 14 commits into from
Jan 6, 2024
Merged

Migrate BFT tests to junit 5 #6350

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
086b551
TestWatcher junit5
macfarla Jan 3, 2024
fc83f23
remove test name rule
macfarla Jan 3, 2024
bcc98d8
formatting
macfarla Jan 3, 2024
694ff81
Merge branch 'main' of github.com:hyperledger/besu into test-watcher-…
macfarla Jan 3, 2024
de6fc1c
add test class and method name to context
macfarla Jan 4, 2024
5d6c431
moved the testwatcher junit5 function to a new junit5 superclass
macfarla Jan 4, 2024
c5798d3
extend from junit5 superclass
macfarla Jan 4, 2024
177ed54
one qbft test to junit5 superclass
macfarla Jan 4, 2024
efd7b46
bft tests to junit 5
macfarla Jan 4, 2024
efda5d3
base class for pki extend AcceptanceTestBaseJunit5
macfarla Jan 4, 2024
b72e4ca
Merge branch 'main' of github.com:hyperledger/besu into bft-test-watc…
macfarla Jan 4, 2024
eba66e3
try/catch in case of empty optionals
macfarla Jan 5, 2024
2140960
fixed parameterization method
macfarla Jan 5, 2024
e17371e
merge main
macfarla Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed parameterization method 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
  • Loading branch information
@macfarla
macfarla committed Jan 5, 2024
commit 2140960e42bbe58f208e48951bbe1432cfae8fcb
11 changes: 5 additions & 6 deletions ...est/java/org/hyperledger/besu/tests/acceptance/bft/BftAcceptanceTestParameterization.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,11 @@ public static Stream<Arguments> getFactories() {
Arguments.of(
"ibft2",
new BftAcceptanceTestParameterization(
BesuNodeFactory::createIbft2Node, BesuNodeFactory::createIbft2NodeWithValidators),
Arguments.of(
"qbft",
new BftAcceptanceTestParameterization(
BesuNodeFactory::createQbftNode,
BesuNodeFactory::createQbftNodeWithValidators))));
BesuNodeFactory::createIbft2Node, BesuNodeFactory::createIbft2NodeWithValidators)),
Arguments.of(
"qbft",
new BftAcceptanceTestParameterization(
BesuNodeFactory::createQbftNode, BesuNodeFactory::createQbftNodeWithValidators)));
}

@FunctionalInterface
Expand Down
Loading