Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fallback to getName when canonicalName is null in BlockHeaderValidator DEBUG log #6332

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Fix: Fallback to getName when canonicalName is null in BlockHeaderValidator DEBUG log #6332

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d2b6cc
fallback to simple name when canonical name is null
manojpramesh Dec 27, 2023
30ccae1
fix formatting
manojpramesh Dec 27, 2023
d6888bd
use getName instead of getSimpleName to include the packagage name
manojpramesh Jan 8, 2024
2c396b7
Merge branch 'main' into fix/6177/null-in-debug-log
macfarla Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fallback to simple name when canonical name is null 
Signed-off-by: Manoj P R <manojpramesh@gmail.com>
  • Loading branch information
@manojpramesh
manojpramesh committed Jan 8, 2024
commit 7d2b6cc930708fe9586a89e65c965a721ca6852d
6 changes: 5 additions & 1 deletion ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/BlockHeaderValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,11 @@ private boolean applyRules(
rule -> {
boolean worked = rule.validate(header, parent, protocolContext);
if (!worked) {
LOG.debug("{} rule failed", rule.innerRuleClass().getCanonicalName());
String canonicalName = rule.innerRuleClass().getCanonicalName();
LOG.debug("{} rule failed", canonicalName == null ?
rule.innerRuleClass().getSimpleName() :
canonicalName
);
}
return worked;
});
Expand Down