Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 23.10.x #6158

Closed
wants to merge 83 commits into from

RC version

9fccdbe
Select commit
Loading
Failed to load commit list.
Closed

Release 23.10.x #6158

RC version
9fccdbe
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Nov 10, 2023 in 1s

DCO

There are 19 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~83 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin release-23.10.x

Summary

Commit sha: 8507bb7, Author: ahamlat, Committer: GitHub; Expected "ahamlat ameziane.hamlat@consensys.net", but got "Ameziane H ameziane.hamlat@consensys.net".
Commit sha: e0b3316, Author: ahamlat, Committer: GitHub; Expected "ahamlat ameziane.hamlat@consensys.net", but got "Ameziane H ameziane.hamlat@consensys.net".
Commit sha: de2d3b4, Author: ahamlat, Committer: GitHub; Expected "ahamlat ameziane.hamlat@consensys.net", but got "Ameziane H ameziane.hamlat@consensys.net".
Commit sha: 9710a9a, Author: ahamlat, Committer: GitHub; Expected "ahamlat ameziane.hamlat@consensys.net", but got "Ameziane H ameziane.hamlat@consensys.net".
Commit sha: a60b31b, Author: daniellehrner, Committer: GitHub; Expected "daniellehrner daniel.lehrner@consensys.net", but got "Daniel Lehrner daniel.lehrner@consensys.net".
Commit sha: 0345b24, Author: delehef, Committer: GitHub; Can not find "delehef franklin.delehelle@odena.eu", in ["delehef github@odena.eu", "Franklin Delehelle franklin.delehelle@odena.eu", "delehef github@odena.eu", "Sally MacFarlane macfarla.github@gmail.com"].
Commit sha: dc2289e, Author: matkt, Committer: GitHub; Expected "matkt karim.t2am@gmail.com", but got "Karim TAAM karim.t2am@gmail.com".
Commit sha: c839a3b, Author: matkt, Committer: GitHub; Expected "matkt karim.t2am@gmail.com", but got "Karim TAAM karim.t2am@gmail.com".
Commit sha: d049cb3, Author: matkt, Committer: GitHub; Expected "matkt karim.t2am@gmail.com", but got "Karim TAAM karim.t2am@gmail.com".
Commit sha: 83ae69a, Author: Matt Whitehead, Committer: GitHub; Expected "Matt Whitehead matthew1001@gmail.com", but got "Matthew Whitehead matthew1001@gmail.com".
Commit sha: 0203092, Author: Matt Whitehead, Committer: GitHub; Can not find "Matt Whitehead matthew1001@gmail.com", in ["Matthew Whitehead matthew1001@gmail.com", "Matthew Whitehead matthew1001@gmail.com", "Matthew Whitehead matthew1001@gmail.com"].
Commit sha: 8afad41, Author: Matt Whitehead, Committer: GitHub; Can not find "Matt Whitehead matthew1001@gmail.com", in ["Matthew Whitehead matthew1001@gmail.com", "Matthew Whitehead matthew1001@gmail.com", "Matthew Whitehead matthew1001@gmail.com", "Matthew Whitehead matthew1001@gmail.com", "Matthew Whitehead matthew1001@gmail.com", "Matthew Whitehead matthew1001@gmail.com"].
Commit sha: 4c3bff3, Author: Matt Whitehead, Committer: GitHub; Expected "Matt Whitehead matthew1001@gmail.com", but got "Matthew Whitehead matthew1001@gmail.com".
Commit sha: 0536a18, Author: NC, Committer: GitHub; Can not find "NC adrninistrator1@protonmail.com", in ["Navie Chan naviechan@gmail.com", "naviechan adrninistrator1@protonmail.com", "Simon Dudley simon.dudley@consensys.net"].
Commit sha: 5fce4fd, Author: NC, Committer: GitHub; Can not find "NC adrninistrator1@protonmail.com", in ["naviechan adrninistrator1@protonmail.com", "Navie Chan naviechan@gmail.com", "Simon Dudley simon.dudley@consensys.net"].
Commit sha: eeb60e5, Author: Stefan Pingel, Committer: GitHub; Expected "Stefan Pingel 16143240+pinges@users.noreply.github.com", but got "Stefan stefan.pingel@consensys.net".
Commit sha: 646c5a3, Author: Stefan Pingel, Committer: GitHub; Expected "Stefan Pingel 16143240+pinges@users.noreply.github.com", but got "stefan.pingel@consensys.net stefan.pingel@consensys.net".
Commit sha: f42f8c1, Author: Stefan Pingel, Committer: GitHub; Expected "Stefan Pingel 16143240+pinges@users.noreply.github.com", but got "stefan.pingel@consensys.net stefan.pingel@consensys.net".
Commit sha: a2dbb82, Author: Suyash Nayan, Committer: GitHub; Can not find "Suyash Nayan 89125422+7suyash7@users.noreply.github.com", in ["Suyash Nayan suyashnyn1@gmail.com", "Sally MacFarlane macfarla.github@gmail.com"].