Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RPCs for yParity #6119

Merged
merged 11 commits into from
Nov 6, 2023
Merged

Update RPCs for yParity #6119

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
015d92f
Update RPCs for yParity
shemnon Nov 3, 2023
73c3b7b
changelog
shemnon Nov 3, 2023
2b9648f
merge
shemnon Nov 3, 2023
ae26562
fix acceptanve test
shemnon Nov 3, 2023
5a399ec
restore ref tests
shemnon Nov 3, 2023
cbe57cb
Merge branch 'main' into graphql_yparity
shemnon Nov 6, 2023
1db29a9
support optional v field
shemnon Nov 6, 2023
b2255ee
support optional v field in rpc responses
shemnon Nov 6, 2023
e7c2eb1
spotless
shemnon Nov 6, 2023
50c2e98
Merge branch 'main' of github.com:hyperledger/besu into graphql_yparity
shemnon Nov 6, 2023
a74742e
tests for adding optional v
shemnon Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
spotless 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
  • Loading branch information
@shemnon
shemnon committed Nov 6, 2023
commit e7c2eb1496e982ac6c58f88201b6e1b48e324a5e
8 changes: 4 additions & 4 deletions .../org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/TransactionPendingResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,10 @@ public TransactionPendingResult(final Transaction transaction) {
this.type = Quantity.create(transactionType.getSerializedType());
this.yParity = Quantity.create(transaction.getYParity());
this.v =
(transactionType == TransactionType.ACCESS_LIST
|| transactionType == TransactionType.EIP1559)
? this.yParity
: null;
(transactionType == TransactionType.ACCESS_LIST
|| transactionType == TransactionType.EIP1559)
? this.yParity
: null;
}
this.value = Quantity.create(transaction.getValue());
this.r = Quantity.create(transaction.getR());
Expand Down