-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAN-3096] privacy on mainnet [WIP] #61
Closed
iikirilov
wants to merge
57
commits into
hyperledger:master
from
iikirilov:pan-3096-privacy-mainnet-rebased
Closed
[PAN-3096] privacy on mainnet [WIP] #61
iikirilov
wants to merge
57
commits into
hyperledger:master
from
iikirilov:pan-3096-privacy-mainnet-rebased
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iikirilov
force-pushed
the
pan-3096-privacy-mainnet-rebased
branch
2 times, most recently
from
September 29, 2019 23:28
e66508c
to
7646ca8
Compare
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/privacy/PrivateStateRootResolver.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, perhaps some refactoring required in PrivateStateRootResolver
iikirilov
requested review from
AbdelStark,
ajsutton,
bgravenorst,
CjHare,
EdJoJob,
jframe,
joshuafernandes,
macfarla,
MadelineMurray,
mark-terry,
mbaxter,
NicolasMassart,
rain-on,
RatanRSur,
rojotek,
shemnon,
timbeiko and
usmansaleem
as code owners
September 30, 2019 16:01
iikirilov
force-pushed
the
pan-3096-privacy-mainnet-rebased
branch
from
September 30, 2019 16:03
435b3e0
to
d3be428
Compare
Reviews were auto-requested from because of #62 |
iikirilov
force-pushed
the
pan-3096-privacy-mainnet-rebased
branch
from
September 30, 2019 16:29
118895f
to
62ad1f7
Compare
Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
Signed-off-by: Ivaylo Kirilov <iikirilov@gmail.com>
iikirilov
force-pushed
the
pan-3096-privacy-mainnet-rebased
branch
from
January 9, 2020 10:07
3a8d04b
to
33321e6
Compare
Superseeded by Lucas's PR |
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Oct 28, 2024
Ensure deploy workflow installs relevant pkgs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ivaylo Kirilov iikirilov@gmail.com
PR description
Adds support for privacy when using consensus mechanisms that do not offer finality
Fixed Issue(s)
[PAN-3096]