Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update evmtool graalvm build #5639

Merged
merged 7 commits into from
Jun 28, 2023
Merged

Update evmtool graalvm build #5639

merged 7 commits into from
Jun 28, 2023

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Jun 24, 2023

PR description

Update EVMTool's GraalVM build

  • add new class to reflection config
  • move CLI output to be system-err oriented
  • make logger in evmtool nop
  • exclude some problematic jars from compilation
    • mixed versions of bouncy castle
    • netty initializations of log4j

Fixed Issue(s)

@shemnon
Update evmtool graalvm build
0c2f901 
* add new class to reflection config
* move CLI output to be system-err oriented
* make logger in evmtool nop
* exclude some problematic jars from compilation
  - mixed versions of bouncy castle
  - netty initializations of log4j

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

shemnon added 3 commits June 24, 2023 20:19
@shemnon
logging fix
bbea34c 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon
Json and crypto
99d4729 
- Standardize JSON ObjectMapper Construction
- Add some manual mappings
- Directly instantiate crypto algorithms where appropriate

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon
readma
bb35788 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 27, 2023
View reviewed changes
crypto/algorithms/src/main/java/org/hyperledger/besu/crypto/MessageDigestFactory.java
case SHA256_ALG -> new SHA256.Digest();
case RIPEMD160_ALG -> new RIPEMD160.Digest();
case BLAKE2BF_ALG -> new Blake2bfMessageDigest();
default -> MessageDigest.getInstance(algorithm);

Check failure

Code scanning / CodeQL

Use of a potentially broken or risky cryptographic algorithm

Cryptographic algorithm [KECCAK-256](1) may not be secure, consider using a different algorithm. Cryptographic algorithm [SHA-256](2) may not be secure, consider using a different algorithm. Cryptographic algorithm [RIPEMD160](3) may not be secure, consider using a different algorithm. Cryptographic algorithm [BLAKE2BF](4) may not be secure, consider using a different algorithm.
shemnon added 2 commits June 27, 2023 11:56
@shemnon
license header
dac7d08 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon
license header
a1bd5c4 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
jflo
jflo approved these changes Jun 27, 2023
View reviewed changes
ethereum/evmtool/src/main/java/org/hyperledger/besu/evmtool/JsonUtils.java
import com.fasterxml.jackson.databind.ser.std.ToStringSerializer;
import org.apache.tuweni.bytes.Bytes;

public class JsonUtils {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good candidate to have Dagger provide an ObjectMapper configured this way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be, but t8n and b11r are not dagger configured (yet).

@shemnon
merge
b49a8df 
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon shemnon enabled auto-merge (squash) June 28, 2023 05:27
@shemnon shemnon merged commit fcdb202 into hyperledger:main Jun 28, 2023
davidkngo pushed a commit to liquichain/besu that referenced this pull request Jun 28, 2023
@shemnon @davidkngo
Update evmtool graalvm build (hyperledger#5639)
b5cc2b4 
* add new class to reflection config
* move CLI output to be system-err oriented
* make logger in evmtool nop
* exclude some problematic jars from compilation
  - mixed versions of bouncy castle
  - netty initializations of log4j
* Standardize JSON ObjectMapper Construction
* Add some manual mappings
* Directly instantiate crypto algorithms where appropriate

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
davidkngo pushed a commit to liquichain/besu that referenced this pull request Jul 21, 2023
@shemnon @davidkngo
Update evmtool graalvm build (hyperledger#5639)
2a6eff4 
* add new class to reflection config
* move CLI output to be system-err oriented
* make logger in evmtool nop
* exclude some problematic jars from compilation
  - mixed versions of bouncy castle
  - netty initializations of log4j
* Standardize JSON ObjectMapper Construction
* Add some manual mappings
* Directly instantiate crypto algorithms where appropriate

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
davidkngo added a commit to liquichain/besu that referenced this pull request Jul 21, 2023
@davidkngo
Revert "Update evmtool graalvm build (hyperledger#5639)"
9d83ae1 
This reverts commit 2a6eff4.
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@shemnon @elenduuche
Update evmtool graalvm build (hyperledger#5639)
bbbc42b 
* add new class to reflection config
* move CLI output to be system-err oriented
* make logger in evmtool nop
* exclude some problematic jars from compilation
  - mixed versions of bouncy castle
  - netty initializations of log4j
* Standardize JSON ObjectMapper Construction
* Add some manual mappings
* Directly instantiate crypto algorithms where appropriate

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@shemnon @eum602
Update evmtool graalvm build (hyperledger#5639)
94b51b9 
* add new class to reflection config
* move CLI output to be system-err oriented
* make logger in evmtool nop
* exclude some problematic jars from compilation
  - mixed versions of bouncy castle
  - netty initializations of log4j
* Standardize JSON ObjectMapper Construction
* Add some manual mappings
* Directly instantiate crypto algorithms where appropriate

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jflo jflo jflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shemnon @jflo