Updates for execution-spec-tests #5638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates needed to keep executing execution-spec-tests * add withdrawals support * add access lists to transactions * accept t8n and b11r CLI args that are zero length or all whitespace * Enumerate forks in t8n and b11r help * remove JSON wrapping from t8n transaction RLP Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ethereum/evmtool/src/main/java/org/hyperledger/besu/evmtool/T8nSubCommand.java
Fixed
Show fixed
Hide fixed
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
jflo
approved these changes
Jun 27, 2023
| @@ -162,6 +195,11 @@ public void run() { | |||
| config.set("txs", t8nReader.readTree(reader)); | |||
| } | |||
| } | |||
| if (!withdrawals.equals(stdinPath)) { | |||
| try (FileReader reader = new FileReader(withdrawals.toFile(), StandardCharsets.UTF_8)) { | |||
| config.set("withdrawals", t8nReader.readTree(reader)); | |||
There was a problem hiding this comment.
I assume using t8nReader as a name for the ObjectMapper here is just copypasta?
There was a problem hiding this comment.
The irony being this was to remove copypasta. Will fix.
…cs-test-june-2023 Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
davidkngo
pushed a commit
to liquichain/besu
that referenced
this pull request
Jun 28, 2023
Updates needed to keep executing execution-spec-tests * add withdrawals support * add access lists to transactions * accept t8n and b11r CLI args that are zero length or all whitespace * Enumerate forks in t8n and b11r help * remove JSON wrapping from t8n transaction RLP Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
davidkngo
pushed a commit
to liquichain/besu
that referenced
this pull request
Jul 21, 2023
Updates needed to keep executing execution-spec-tests * add withdrawals support * add access lists to transactions * accept t8n and b11r CLI args that are zero length or all whitespace * Enumerate forks in t8n and b11r help * remove JSON wrapping from t8n transaction RLP Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
davidkngo
added a commit
to liquichain/besu
that referenced
this pull request
Jul 21, 2023
This reverts commit aff2df0.
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
Updates needed to keep executing execution-spec-tests * add withdrawals support * add access lists to transactions * accept t8n and b11r CLI args that are zero length or all whitespace * Enumerate forks in t8n and b11r help * remove JSON wrapping from t8n transaction RLP Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Updates needed to keep executing execution-spec-tests * add withdrawals support * add access lists to transactions * accept t8n and b11r CLI args that are zero length or all whitespace * Enumerate forks in t8n and b11r help * remove JSON wrapping from t8n transaction RLP Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Updates needed to keep executing execution-spec-tests
Fixed Issue(s)