Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4844] Add toString to VersionedHash #5610

Merged
merged 1 commit into from
Jun 16, 2023
Merged

[4844] Add toString to VersionedHash #5610

merged 1 commit into from
Jun 16, 2023

Conversation

Gabriel-Trintinalia
Copy link
Contributor

PR description

Add toString to VersionedHash and set it to be the JsonValue of the VersionedHash object

Actual:

{
...
  blobVersionedHashes: [{
      versionId: 1
  }, {
      versionId: 1
  }, {
      versionId: 1
  }, {
      versionId: 1
  }, {
      versionId: 1
  }, {
      versionId: 1
  }],
 ...
}

Expected:

{
...
  blobVersionedHashes: ["0x01a8a4a49dcd1b91c376c87d7d6a6e73ee3792205864bf61781e8e3ad19d0092", 
"0x01069693395fb9a698b257e6c25380f32393bc0cf17a290f9e7fcea3c4ae7b8b", 
"0x01111dafbfcc0caa0803fc22f697fd3b9171252504e14ec0443f04a2b3288715", 
"0x01d1dfff9c15b3201980d8f9b958a8ade73e3e1e0ca76c54785a33e09519be7a", 
"0x01a7b4b55dd68d59685abcd629708c5de44c8e9edf3671602538eba23375893c", 
"0x013586020d67ab6808e681c2e6a2d1e854c84e5bc49df2ed34e218eace844f8b"],
...
}

@Gabriel-Trintinalia
Add toString to VersionedHash
4dd651f 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as ready for review June 16, 2023 03:58
pinges
pinges approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 4890413 into hyperledger:4844-devnet-5b Jun 16, 2023
jflo pushed a commit that referenced this pull request Jun 16, 2023
@Gabriel-Trintinalia @jflo
Add toString to VersionedHash (#5610)
4853005 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the fix-versioned-hash-json-issue branch June 19, 2023 03:35
jflo pushed a commit that referenced this pull request Jun 21, 2023
@Gabriel-Trintinalia @jflo
Add toString to VersionedHash (#5610)
7a95757 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo pushed a commit that referenced this pull request Jun 29, 2023
@Gabriel-Trintinalia @jflo
Add toString to VersionedHash (#5610)
27e6435 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo pushed a commit that referenced this pull request Jun 30, 2023
@Gabriel-Trintinalia @jflo
Add toString to VersionedHash (#5610)
9429866 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo pushed a commit that referenced this pull request Jul 5, 2023
@Gabriel-Trintinalia @jflo
Add toString to VersionedHash (#5610)
c594e66 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@Gabriel-Trintinalia @jflo
Add toString to VersionedHash (hyperledger#5610)
030bc8b 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinges pinges pinges approved these changes

Assignees
No one assigned
Labels
4844 mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabriel-Trintinalia @pinges