Renumber EOF and Transient storage #5550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per a recent ACD, the opcode numbers for EOF and Transient Storage have been updated. Update the code and test cases for the new numbers. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
|
shemnon
changed the title
macfarla
reviewed
Jun 9, 2023
| VALID, // 0X5e - RJUMPV | ||
| VALID, // 0X5c - TLOAD | ||
| VALID, // 0X5d - TSTORE | ||
| INVALID, // 0X5e |
There was a problem hiding this comment.
should this be VALID for MCOPY
There was a problem hiding this comment.
This PR was submitted before the MCOPY PR merged
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
As per a recent EIP update the opcode numbers for Transient Storage have been updated. EOF opcodes were also updated. Update the code and test cases for the new numbers. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
As per a recent EIP update the opcode numbers for Transient Storage have been updated. EOF opcodes were also updated. Update the code and test cases for the new numbers. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
As per a recent ACD, the opcode numbers for EOF and Transient Storage have been updated. Update the code and test cases for the new numbers.
Updated list https://hackmd.io/@shemnon/CancunOpcodeAllocation
Fixed Issue(s)