Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR checklist - remove checkbox for non-mainnet ATs #5514

Merged
merged 3 commits into from
May 30, 2023
Merged

PR checklist - remove checkbox for non-mainnet ATs #5514

merged 3 commits into from
May 30, 2023

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented May 30, 2023 •
edited
Loading

these are now run in CI on each PR per #5502

macfarla added 2 commits May 30, 2023 11:37
@macfarla
removed non-mainnetATs line
1fe6500 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
typo
44760ce 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@macfarla macfarla enabled auto-merge (squash) May 30, 2023 20:09
@macfarla macfarla merged commit db41062 into hyperledger:main May 30, 2023
@macfarla macfarla deleted the pr-checklist branch June 22, 2023 01:49
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@macfarla @elenduuche
PR checklist - remove checkbox for non-mainnet ATs (hyperledger#5514)
b84ab66 
* removed non-mainnetATs line

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@macfarla @eum602
PR checklist - remove checkbox for non-mainnet ATs (hyperledger#5514)
54bd693 
* removed non-mainnetATs line

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfukushima gfukushima gfukushima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @gfukushima