Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrieLogFactory plugin support #5440

Merged
merged 30 commits into from
May 15, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
5b22397
ZkTrieLogFactoryImpl, rebased off of main
garyschulte Apr 24, 2023
d92bcfd
code before account
garyschulte Apr 24, 2023
4dc1832
trielog shipping observer
garyschulte Apr 24, 2023
6b10603
use hex encoding in trielog shipping, add a TESTING default ZkTrieLog…
garyschulte Apr 25, 2023
0ca5fc0
fix unintended recursion
garyschulte Apr 26, 2023
4eb6e1d
filter out self destruct storage changes in ZkTrieLogImpl
garyschulte Apr 26, 2023
1248885
store both slotHash and slotKey, defer to shomei to handle it as it s…
garyschulte Apr 27, 2023
b6c4ed2
reorder trielog storage to differentiate between ZERO slot key and nu…
garyschulte Apr 27, 2023
08120b0
do not filter unchanged accounts for zktrielogfactory
garyschulte Apr 27, 2023
f089122
use blockHeader during trielog construction, add blockNumber to triel…
garyschulte Apr 27, 2023
e1f8dc7
add blockNumber to rpc call to shomei
garyschulte Apr 28, 2023
f873ae5
add isSyncing to the trieLogParameter and ZkTrieLogObserver
garyschulte May 4, 2023
c659c4a
initial plumbing for trielog shipping plugin
garyschulte May 5, 2023
5e8c35f
halfway through generics hell
garyschulte May 5, 2023
126f46d
TrieLogs in plugin data
garyschulte May 5, 2023
a032562
end of friday, green build with plugin refactoring, still need to add…
garyschulte May 6, 2023
0b37f10
remove errant reference to ZkTrieLogFactory
garyschulte May 6, 2023
3cd90d2
adding dagger-wired plugincontext and TrieLogService
garyschulte May 8, 2023
3c867b9
javadoc and fixes
garyschulte May 8, 2023
e7ad166
add plugin observer subscription
garyschulte May 8, 2023
c5e2019
plugin-api hash
garyschulte May 9, 2023
d5724c2
fix besuComponent ref, move addService up into BesuContext
garyschulte May 9, 2023
1b5f858
add TrieLogRangePair composition of blocknumber and TrieLog, use that…
garyschulte May 9, 2023
d4e79c6
javadoc
garyschulte May 9, 2023
2762389
move TrieLog from datatypes to plugin-api
garyschulte May 10, 2023
f479ea0
add blockHash to TrieLogRangeTuple
garyschulte May 10, 2023
483346b
adjust besuComponent mocks
garyschulte May 12, 2023
67b02f2
spotless and javadoc
garyschulte May 12, 2023
402caec
javadoc
garyschulte May 12, 2023
bae88e3
review feedback
garyschulte May 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
javadoc
Signed-off-by: garyschulte <garyschulte@gmail.com>
  • Loading branch information
garyschulte committed May 15, 2023
commit d4e79c61d305dcb8819eb0d2342a8ddffe7e6fbc
2 changes: 1 addition & 1 deletion plugin-api/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Calculated : ${currentHash}
tasks.register('checkAPIChanges', FileStateChecker) {
description = "Checks that the API for the Plugin-API project does not change without deliberate thought"
files = sourceSets.main.allJava.files
knownHash = 'ShN4Vv2TYtTP6MhUex1whS6XAgYzK7itvJl3Q4VYOA0='
knownHash = 'nQ4sgzgeGXts5YKfNUQN0urTXtGGk2QfzB9V6BDNAYc='
}
check.dependsOn('checkAPIChanges')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,11 @@ public interface TrieLogProvider {
<T extends TrieLog.LogTuple<?>> List<TrieLogRangePair> getTrieLogsByRange(
long fromBlockNumber, long toBlockNumber);

/**
* Block and TrieLog layer composition, used for returning a range of TrieLog layers.
*
* @param blockNumber the block number
Fixed Show fixed Hide fixed

Check notice

Code scanning / CodeQL

Spurious Javadoc @param tags

@param tag "blockNumber" does not match any actual type parameter of type "TrieLogRangeTuple".
* @param trieLog the associated TrieLog layer
Fixed Show fixed Hide fixed

Check notice

Code scanning / CodeQL

Spurious Javadoc @param tags

@param tag "trieLog" does not match any actual type parameter of type "TrieLogRangeTuple".
*/
record TrieLogRangePair(long blockNumber, TrieLog trieLog) {}
}