Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare main for next point release #5380

Merged
merged 4 commits into from
Apr 21, 2023
Merged

prepare main for next point release #5380

merged 4 commits into from
Apr 21, 2023

Conversation

garyschulte
Copy link
Contributor

PR description

update changelog
prep for next point release

Fixed Issue(s)

@garyschulte
changelog fix-up
60b1fd3 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte
prep main for next point release
cc1faf5 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@garyschulte
add 23.4.0-RC1 shas
5d67441 
Signed-off-by: garyschulte <garyschulte@gmail.com>
siladu
siladu reviewed Apr 21, 2023
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is the right PR - or maybe both - I think we need to shift the changelog from 23.1.3 into RC1, all except the payloadId fix

siladu
siladu approved these changes Apr 21, 2023
View reviewed changes
CHANGELOG.md Outdated
Comment on lines 40 to 41
https://hyperledger.jfrog.io/hyperledger/besu-binaries/besu/23.4.0-RC1/besu-23.4.0-RC1.tar.gz / sha256: 0eebe041c1eb8d16587de1f6d19355a0ec7845fcb0e66a6a96d36bbd376311d3
https://hyperledger.jfrog.io/hyperledger/besu-binaries/besu/23.4.0-RC1/besu-23.4.0-RC1.zip / sha256: f0b4657d88d07a6aea0457c18e227ecf9bc1fdd942fe411e12996962a9c4e08f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHAs look good 👍

@garyschulte
fix changelog
8ceeb24 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte merged commit 4875ba3 into hyperledger:main Apr 21, 2023
@garyschulte garyschulte deleted the update-changelog branch April 21, 2023 22:33
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@garyschulte @elenduuche
prepare main for next point release (hyperledger#5380)
cc706c8 
* prep main for next point release
* changelog fix-up

Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@garyschulte @eum602
prepare main for next point release (hyperledger#5380)
6d93978 
* prep main for next point release
* changelog fix-up

Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyschulte @siladu