-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional log to indicate that database is compacting #5359
Merged
macfarla
merged 4 commits into
hyperledger:main
from
daniellehrner:log_message_db_cleanup
Apr 20, 2023
Merged
Additional log to indicate that database is compacting #5359
macfarla
merged 4 commits into
hyperledger:main
from
daniellehrner:log_message_db_cleanup
Apr 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when opening an existing one. Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
|
non-fungible-nelson
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great catch
garyschulte
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, spotless notwithstanding
@daniellehrner can you handle a merge by friday? |
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
…when opening an existing one. (hyperledger#5359) Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…when opening an existing one. (hyperledger#5359) Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Besu is restarted after running for a few days the startup can appear to be stuck:
The example above shows a 12 seconds difference between the two log messages. In other occasions I've seen it taking longer than 30 seconds. Looking at Grafana it seems that the database is compacting during this time:
This PR adds this information to the log message to tell the user what is going on, so they don´t think that there is a problem.