Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update most dependecies to latest version #5269

Merged
merged 15 commits into from
Apr 4, 2023
Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Mar 24, 2023

PR description

Vertx, Prometheus and Mockito are not update to latest version since there are some breaking changes and we need to update our code, will track their update in separate tickets.

Fixed Issue(s)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@github-actions
Copy link

github-actions bot commented Mar 24, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
  • I thought about the changelog and included a changelog update if required.

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 changed the title Update vertx Update dependecies to latest version Mar 24, 2023
Copy link
Contributor

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this updates a number of dependencies, perhaps it is about time to re-generate verification-metadata.xml (As described in https://docs.gradle.org/current/userguide/dependency_verification.html#sec:verification-metadata-hygiene) from scratch to clean out prior versions.

fab-10 added 11 commits March 31, 2023 19:32
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 changed the title Update dependecies to latest version Update most dependecies to latest version Apr 4, 2023
@fab-10 fab-10 self-assigned this Apr 4, 2023
@fab-10
Copy link
Contributor Author

fab-10 commented Apr 4, 2023

Since this updates a number of dependencies, perhaps it is about time to re-generate verification-metadata.xml (As described in https://docs.gradle.org/current/userguide/dependency_verification.html#sec:verification-metadata-hygiene) from scratch to clean out prior versions.

There is some value in keeping the verification for older version,, in the case we need to rollback an update, we alreadu have the right checksum w/o having to trust it again, but this should be very rare and so I agree that make sense to do a cleanup now.

@fab-10 fab-10 force-pushed the update-vertx branch 3 times, most recently from 90071b8 to f65c1fa Compare April 4, 2023 13:32
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 enabled auto-merge (squash) April 4, 2023 14:34
@fab-10 fab-10 merged commit 557c568 into hyperledger:main Apr 4, 2023
@fab-10 fab-10 deleted the update-vertx branch April 4, 2023 14:59
jflo pushed a commit to jflo/besu that referenced this pull request Apr 5, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants