Sonarcloud Analysis once a week. #5137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
siladu
approved these changes
Feb 24, 2023
| @@ -86,7 +86,7 @@ APP_NAME="Gradle" | |||
| APP_BASE_NAME=${0##*/} | |||
|
|
|||
| # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. | |||
| DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' | |||
| DEFAULT_JVM_OPTS='"-Xmx1024m" "-Xms256m"' | |||
There was a problem hiding this comment.
Isn't gradle.properties taking precedence and so this is unnecessary?
There was a problem hiding this comment.
Sadly, it is necessary due to out of memory conditions we encountered while compiling.
There was a problem hiding this comment.
I wonder if that will get blatted away the next time we update gradle 🤔
There was a problem hiding this comment.
...looks like you might be about to find out :)
#5144
cc @usmansaleem
macfarla
approved these changes
Feb 26, 2023
jframe
approved these changes
Feb 26, 2023
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* fixing the sonarcloud building in gha * update to temurin 17 * adds checksums on sonarqube plugins * ignore generated for spdx * runs at midnight Tuesday mornings UTC --------- Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Joshua Fernandes <joshua.fernandes@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* fixing the sonarcloud building in gha * update to temurin 17 * adds checksums on sonarqube plugins * ignore generated for spdx * runs at midnight Tuesday mornings UTC --------- Signed-off-by: Joshua Fernandes <joshua.fernandes@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Joshua Fernandes <joshua.fernandes@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs sonarqube analysis as a github action once a week, on Tuesday mornings at midnight, UTC. Memory requirements have increased to 4G heap.
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Acceptance Tests (Non Mainnet)
./gradlew acceptanceTestNonMainnetlocally if my PR affects non-mainnet modules.Changelog