Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-default global max rpc batch size to 1k #5104

Merged
merged 4 commits into from
Feb 17, 2023
Merged

re-default global max rpc batch size to 1k #5104

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97c8384
default global max rpc batch size to 1000 for now
garyschulte Feb 17, 2023
9362789
update changelog
garyschulte Feb 17, 2023
5058778
update default engine max batch size, add to toString, equals and has…
garyschulte Feb 17, 2023
d642be2
fix primitive equals comparison
garyschulte Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update default engine max batch size, add to toString, equals and has… 
…hCode

Signed-off-by: garyschulte <garyschulte@gmail.com>
  • Loading branch information
@garyschulte
garyschulte committed Feb 17, 2023
commit 50587784e3da920ee86ae548e14fe7fc8bb053f6
9 changes: 6 additions & 3 deletions ...eum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class JsonRpcConfiguration {
public static final int DEFAULT_JSON_RPC_PORT = 8545;
public static final int DEFAULT_ENGINE_JSON_RPC_PORT = 8551;
public static final int DEFAULT_MAX_ACTIVE_CONNECTIONS = 80;
public static final int DEFAULT_MAX_BATCH_SIZE = 1;
public static final int DEFAULT_MAX_BATCH_SIZE = 1000;

private boolean enabled;
private int port;
Expand Down Expand Up @@ -208,6 +208,7 @@ public String toString() {
.add("tlsConfiguration", tlsConfiguration)
.add("httpTimeoutSec", httpTimeoutSec)
.add("maxActiveConnections", maxActiveConnections)
.add("maxBatchSize", maxBatchSize)
.toString();
}

Expand All @@ -228,7 +229,8 @@ public boolean equals(final Object o) {
&& Objects.equals(rpcApis, that.rpcApis)
&& Objects.equals(hostsAllowlist, that.hostsAllowlist)
&& Objects.equals(authenticationCredentialsFile, that.authenticationCredentialsFile)
&& Objects.equals(authenticationPublicKeyFile, that.authenticationPublicKeyFile);
&& Objects.equals(authenticationPublicKeyFile, that.authenticationPublicKeyFile)
&& Objects.equals(maxBatchSize, that.maxBatchSize);
}

@Override
Expand All @@ -242,7 +244,8 @@ public int hashCode() {
hostsAllowlist,
authenticationEnabled,
authenticationCredentialsFile,
authenticationPublicKeyFile);
authenticationPublicKeyFile,
maxBatchSize);
}

public int getMaxActiveConnections() {
Expand Down