Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verfifying kzg proof #4994

Merged
merged 1 commit into from
Jan 24, 2023
Merged

verfifying kzg proof #4994

merged 1 commit into from
Jan 24, 2023

Conversation

gezero
Copy link
Contributor

@gezero gezero commented Jan 24, 2023

Signed-off-by: Jiri Peinlich jiri.peinlich@gmail.com

@gezero
verfifying kzg proof
e060262 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
garyschulte
garyschulte reviewed Jan 24, 2023
View reviewed changes
...um/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetTransactionValidator.java
Comment on lines +50 to +52
private final long MAX_DATA_GAS_PER_BLOCK = 524_288; // 2**19
private final long DATA_GAS_PER_BLOB = 131_072; // 2**17
private final byte BLOB_COMMITMENT_VERSION_KZG = 0x01;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be defined elsewhere, but fine for test net

garyschulte
garyschulte reviewed Jan 24, 2023
View reviewed changes
...um/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetTransactionValidator.java
Comment on lines +310 to +314
if (transaction.getBlobsWithCommitments().isEmpty()) {
return ValidationResult.invalid(
TransactionInvalidReason.INVALID_BLOBS,
"transaction blobs are empty, cannot verify without blobs");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be cleaned up, good for testnet

garyschulte
garyschulte approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@gezero gezero merged commit 8e3a912 into hyperledger:eip-4844-interop Jan 24, 2023
jflo pushed a commit to jflo/besu that referenced this pull request May 9, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
50a0faf 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request May 10, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
d7918dd 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request May 15, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
16bd1c4 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request May 16, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
048a773 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request May 17, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
7d3cc9d 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request May 18, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
f685304 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request May 22, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
9114a16 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request May 22, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
9f58dcf 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request May 24, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
6fef25a 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request May 24, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
e9644ff 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request May 31, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
c4eeabb 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request May 31, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
7bd0b61 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request May 31, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
81224fb 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request May 31, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
083e8d3 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request Jun 5, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
1017a5e 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request Jun 5, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
6138f12 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request Jun 7, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
de3363e 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request Jun 7, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
d596864 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 13, 2023
@gezero @jflo
verfifying kzg proof (#4994)
093970d 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 13, 2023
@gezero @jflo
verfifying kzg proof (#4994)
1312e72 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 14, 2023
@gezero @jflo
verfifying kzg proof (#4994)
376b754 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 14, 2023
@gezero @jflo
verfifying kzg proof (#4994)
5ca5991 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 15, 2023
@gezero @jflo
verfifying kzg proof (#4994)
a75ffb8 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 15, 2023
@gezero @jflo
verfifying kzg proof (#4994)
82efda6 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 16, 2023
@gezero @jflo
verfifying kzg proof (#4994)
f748958 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 16, 2023
@gezero @jflo
verfifying kzg proof (#4994)
a8eb207 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 21, 2023
@gezero @jflo
verfifying kzg proof (#4994)
0a50db8 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 21, 2023
@gezero @jflo
verfifying kzg proof (#4994)
7125117 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 29, 2023
@gezero @jflo
verfifying kzg proof (#4994)
9d88480 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 29, 2023
@gezero @jflo
verfifying kzg proof (#4994)
77c6f0a 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 30, 2023
@gezero @jflo
verfifying kzg proof (#4994)
8b12043 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jun 30, 2023
@gezero @jflo
verfifying kzg proof (#4994)
8315c8d 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jul 5, 2023
@gezero @jflo
verfifying kzg proof (#4994)
8e9cbbc 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit that referenced this pull request Jul 5, 2023
@gezero @jflo
verfifying kzg proof (#4994)
e5e4eca 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
fbb64a9 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@gezero @jflo
verfifying kzg proof (hyperledger#4994)
0b4f260 
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
(cherry picked from commit 8e3a912)
(cherry picked from commit c325682b0f8acadc411acd6daafb55f5941785a0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyschulte garyschulte garyschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gezero @garyschulte