Change JSON RPC Error-32602 (Invalid Params) to return with http status code 200 #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
siladu
approved these changes
Jan 20, 2023
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| ### Breaking Changes | |||
|
|
|||
| - Changed JsonRpc http service to return the error -32602 (Invalid params) with a 200 http status code | |||
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
…us code 200 (hyperledger#4967) * Handle INVALID_PARAMS with a 200 http status code * Change tests to expect INVALID_PARAMS with a 200 http status code * Add change log entry * Change test to handle jsonRPC result rather than raised exception Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…us code 200 (hyperledger#4967) * Handle INVALID_PARAMS with a 200 http status code * Change tests to expect INVALID_PARAMS with a 200 http status code * Add change log entry * Change test to handle jsonRPC result rather than raised exception Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR changes the JsonRpc http service to return the error -32602 (Invalid params) with a 200 http status code.
Fixed Issue(s)
Linked to #4747
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog