Fix transaction pool issue #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
reviewed
Jan 19, 2023
| } | ||
| return mutableWorldstate.map( |
There was a problem hiding this comment.
on second thought, this has the potential to leak snapshots and prevent compaction if the mutable worldstate is not explicitly closed.
There was a problem hiding this comment.
I will do as before. I cannot see easy way to manage that . I wanted to create an OptionalMutableWorldstate with only a ifPresent that close the ressource automatically but seems to be a big and complex modification
matkt
force-pushed
the
feature/fix-transaction-pool
branch
from
53bc9fb to
db0b785
Compare
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
* make RocksDBSnapshotTransction.commit() no-op rather than throw * in SnaphotUpdater: ** keep a single reference to snapshot transaction rather than storage and accessor ** commit all storage transactions instead of just trieLogTransaction (for rocksdb all other tx commits are no-op) Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/fix-transaction-pool
branch
from
145f7e9 to
813860c
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/fix-transaction-pool
branch
from
813860c to
13a2b93
Compare
garyschulte
force-pushed
the
feature/fix-transaction-pool
branch
from
9503f94 to
13a2b93
Compare
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Feb 5, 2023
* fix transaction pool issue * add block replay * support in-memory snapshots Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Feb 5, 2023
* fix transaction pool issue * add block replay * support in-memory snapshots Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo
added a commit
that referenced
this pull request
Feb 8, 2023
* Fix transaction pool issue (#4964) * Cache empty slots (#4874) * clear after each block and copy during clone * fix transaction pool issue * add block replay * support in-memory snapshots * Keep Worldstate Storage open for Bonsai archive latest layer (#5039) * bonsai layered worldstate subscription * unsubscribe from worldstatestorage on close of BonsaiLayeredWorldState * minor txpool logging improvements * Avoid triggering a calculate root hash when empty slot cache is not empty. * use the updater cache to get an account during block processing (#4897) * Worldstate-only resync behavior (#4875) * use debug rpc endpoint to resync worldstate * Reset transaction pool state every time the initial sync is done * init heal code --------- Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: ahamlat <ameziane.hamlat@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: matkt <karim.t2am@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: ahamlat <ameziane.hamlat@consensys.net> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* fix transaction pool issue * add block replay * support in-memory snapshots Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* fix transaction pool issue * add block replay * support in-memory snapshots Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karim TAAM karim.t2am@gmail.com
PR description
There has been a regression on Besu regarding the transaction pool. Indeed it seems that the transaction pool validation part does not make a copy of the worldstate during the GetMutable and this means that we can have a version which can change and which is not safe. A copy mechanism has been set up which allows to use the snapshot and to protect against worldstate modifications during validation. it was used elsewhere except in transaction pool validation and block replay.
This caused us to invalidate too many transactions
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog